Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate refresh_ems class method to parent cloud manager #874

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

nasark
Copy link
Member

@nasark nasark commented Oct 30, 2024

Refreshes should be done via the cloud manager. Instance methods are already delegated however the class level refresh methods were not delegated.

Following changes in ManageIQ/manageiq-providers-azure#564

@miq-bot assign @agrare
@miq-bot add_label bug
@miq-bot add_reviewer @agrare

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM
I notice we still do the old "queue refresh of child managers" in the CloudManager/Refresher this is something we should convert over here also

@agrare agrare merged commit 6aa6433 into ManageIQ:master Oct 30, 2024
4 checks passed
@nasark
Copy link
Member Author

nasark commented Oct 30, 2024

@miq-bot add_label radjabov/yes?

@Fryguy
Copy link
Member

Fryguy commented Nov 4, 2024

Backported to radjabov via merge of master into radjabov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants